Repository navigation
Conversation
`sb('fn()')` used the `debug()` command line API, which gives no
breakpoint id, so these breakpoints never showed up in `breakpoints`
and could not be removed with `cb`. Use
`Debugger.setBreakpointOnFunctionCall` instead and keep the breakpoint
in the list, so it is listed as `fn()` and can be cleared with
`cb('fn()')`.
Fixes: nodejs#41790
Co-authored-by: Dan Rose <danoftheroses@gmail.com>
Signed-off-by: dualfroz <me@dualfroz.com>
nodejs-github-bot
added
debugger
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66744 +/- ##
=======================================
Coverage 90.47% 90.48%
=======================================
Files 791 791
Lines 277225 277232 +7
Branches 53313 53331 +18
=======================================
+ Hits 250829 250855 +26
+ Misses 16801 16789 -12
+ Partials 9595 9588 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #41790
picks up #53798 by @rotu (kept as co-author).
sb('fn()')wentthrough
debug()from the command line API, so there was nobreakpoint id to keep. it now uses
Debugger.setBreakpointOnFunctionCall,the breakpoint shows up in
breakpointsasfn()andcb('fn()')removes it. like before, these aren't restored after
restart.test-debugger-breakneeded a small update since the functionbreakpoint is now listed and the pause reads
break in.